Closed rapoliveira closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.52%. Comparing base (
6fabea2
) to head (959f353
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please remove # , minor=True)
due to Jen's rule no. 1: "Don't leave unused code".
Also please change version to 0.34.4.
@rpoleski To make sure I don't forget and since this second Y-axis has a different scale, I created a small function to handle its minor ticks. I already changed the version, but I'm open to suggestions!
A few more changes are needed:
_mark_second_Y_axis_in_best_plot()
got quite long, so please split it into shorter functions (Jen's rule no. 2: "Functions should be shorter than 20 lines.",sb_fluxes
is unclear to me (and not explained in docstings) - please modify it.@rpoleski Done!
sb_fluxes
-> ref_fluxes
in _second_Y_axis_minor_ticks()
and it will be finished.
Minor changes were applied to the magnification second Y-axis, as suggested by Jason. I changed the color to
'black'
, label to 'Magnifications' and ticks to'inside'
.Minor ticks (as in issue #118) were left for the future, since the axis scale is neither linear or log.