rpoleski / MulensModel

Microlensing Modelling package
https://rpoleski.github.io/MulensModel/
Other
57 stars 15 forks source link

Init Github actions CI python-app.yml #60

Closed justi closed 1 year ago

rpoleski commented 2 years ago

Build failed in a use case 11. I've corrected that use case, but in general we don't want to test use cases as this is our "make a wish" code.

justi commented 2 years ago

@rpoleski could you commit your changes here? We will check the pipeline with the fixed code. The tests don run yet because syntax errors/undefined names are here. After the lint check it pytest will be called.

rpoleski commented 2 years ago

Right! It makes sense to commit here :)

justi commented 2 years ago

@rpoleski looks like some code changes from master cause 2 new fails

rpoleski commented 2 years ago

I bet the CI is installing some different version than the code here. In this branch line 59 of magnificationcurve.py says TypeError but the CI pytest says ValueError (line 57 in "Test with pytest" section).

justi commented 2 years ago

Thats wired. But when I fetched this branch and run pytest, the same fails appear.

justi commented 2 years ago

Ok, I see where the problem is. When I use 'pip install MulensModel' the library is installed from the master branch. From this time pytest runs on the library, not a local repo code. How to fix it? We need to remove this installation step and rewrite it to use the code from the repo instead.

rpoleski commented 2 years ago

I don't get it - I've updated the PyPI version in the meantime by making a release. I don't know what version of MM is installed here. Any ideas how to correct it?

rpoleski commented 2 years ago

No CI is completed. @justi what is the next step? Should I merge it? It would be good if you could configure also a run of coverage, so that we could inspect results easily.

justi commented 2 years ago

At this moment I see the CI passed, good job :) I can check how to configure test coverage.

rpoleski commented 1 year ago

Sorry for distraction - the last two commits should be to master branch.