Xallarap TO-DO list

[rpoleski]

What to do in xal branch:

• [x] Check if there is something useful in xallarap branch; delete that branch afterwards.
• [x] Should orbit reference epoch be one of possible xallarap parameters? Note that we already have t_0_xi (typically equal to t_0_par) - NOT at this point.
• [x] Update documents/parameter_names.tex.
• [x] xi_Omega_node and xi_argument_of_latitude_reference - docstrings in modelparameters.py.
• [x] Trajectory._get_shifts_xallarap() - I think we can call Orbit class there and don't have to try OrbitCircular directly. This change will simplify the code.
• [x] Add tests to ModelParameters._check_valid_combination_1_source_standard().
• [x] Xallarap and binary source are currently forbidden - UNIT TEST
• [x] Xallarap and Cassan08 parameterization are forbidden
• [x] Xallarap and chi2 gradient - currently forbidden - UNIT TEST
• [x] consider removing *args from Orbit.__new__(), so that it's the parameters uniquely define the child class
• [x] Parallax and xallarap - Do relative mu in both have to agree? Answer: no.
• [x] Test Model._plot_arrow().
• [x] Check if all examples work. 2023-07-13: xal: bc038e8 master: cb303e4; issues: 1) last plot in ex20
• [x] eccentricity in MM - see the list of tasks in the post below (on Jul 13)
• [x] Add link to wiki on orbital parameters definitions (wiki1, wiki2, image from wiki).
• [x] lines marked "XXX" in modelparameters.py.
• [x] Docstrings for added tests.
• [x] For OrbitCircular change: periapsis_epoch -> ascending_node_epoch
• [x] AT THE END - flake8, version number, sphinx, README.md

[rpoleski]

Changes to example 16 from the comit b97f2a5 are also useful for the master branch. They allow to read starting points from a file in EMCEE fitting.

[rpoleski]

Eccentric orbit requires updates:

• [x] documents/parameter_names.tex
• [x] ModelParameters.__repr__()
• [x] ModelParameters._check_valid_combination_1_source_xallarap()
• [x] ModelParameters._check_valid_combination_1_source()
• [x] ModelParameters._check_valid_combination_1_source_standard()
• [x] ModelParameters._set_parameters()
• [x] ModelParameters._check_valid_parameter_values()
• [x] ModelParameters - add parameters there
• [x] test_xallarap_at_t_0() in test_Model.py
• [x] test_xallarap_at_t_0_plus_half_of_period_1() in test_Model.py

[rpoleski]

@jenniferyee

1. Do you want to review this code once more before merging? Please let me know ASAP. If not, then I'd like to merge it on Monday.
2. Do you think I should change class name: OrbitCircular -> CircularOrbit? For me, the former has an advantage of being ready to be expanded in a logical way, e.g., OrbitCircularFromStateVector.

[rpoleski]

@jenniferyee - one more point to discuss: should the xallarap parameters start with xi_ or with chi_? I think I've seen both conventions in the papers.

[rpoleski]

I've just found that recent papers (Miyake et al. 2012, Miyazaki et al. 2020, Rota et al. 2021) use Greek xi for the xallarap parameters, so I'll stay with that if there are no other comments today.

[jenniferyee]

I prefer xi because chi is used for chi2.

Dr. Jennifer C. Yee (she/her)

Office: P-341 Center for Astrophysics | Harvard & Smithsonian 60 Garden St, MS-15 Cambridge, MA 02138

On Mon, Jul 24, 2023 at 4:45 AM Radek Poleski @.***> wrote:

I've just found that recent papers (Miyake et al. 2012 https://ui.adsabs.harvard.edu/abs/2012ApJ...752...82M/abstract, Miyazaki et al. 2020 https://ui.adsabs.harvard.edu/abs/2020AJ....159...76M/abstract, Rota et al. 2021 https://ui.adsabs.harvard.edu/abs/2021AJ....162...59R/abstract) use Greek xi for the xallarap parameters, so I'll stay with that if there are no other comments today.

— Reply to this email directly, view it on GitHub https://github.com/rpoleski/MulensModel/issues/86#issuecomment-1647479391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEK7UCMSMLG3GFVIXYEIQLTXRYYY7ANCNFSM6AAAAAAYOWG6R4 . You are receiving this because you were mentioned.Message ID: @.***>

[rpoleski]

Merged. 264 unit tests and 74% coverage of code using tests at this point.

[jenniferyee]

woot woot!

Dr. Jennifer C. Yee (she/her)

Office: P-341 Center for Astrophysics | Harvard & Smithsonian 60 Garden St, MS-15 Cambridge, MA 02138

On Tue, Jul 25, 2023 at 9:31 AM Radek Poleski @.***> wrote:

Closed #86 https://github.com/rpoleski/MulensModel/issues/86 as completed.

— Reply to this email directly, view it on GitHub https://github.com/rpoleski/MulensModel/issues/86#event-9911832229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEK7UCPKFPKJOF3P7RM7MS3XR7DCNANCNFSM6AAAAAAYOWG6R4 . You are receiving this because you were mentioned.Message ID: @.***>