search

rpoleski / MulensModel

Microlensing Modelling package
https://rpoleski.github.io/MulensModel/
Other
57 stars 15 forks source link

Plotting of poor-quality data #87

Closed rpoleski closed 1 year ago

rpoleski commented 1 year ago

Uliana has pointed out to me that MM fails sometimes in plotting datasets. We checked that these datasets are of poor quality (only 2 epochs, or only noisy data near baseline) and they have negative source flux. Hence, while scaling the errorbars, they take negative values, which then makes pyplot to fail. We definitely should correct that. We can do:

  1. just skip such a dataset while plotting,
  2. plot this dataset but without errorbars.

In both cases we should give a warning. I think the latter approach will be misleading: if we plot 5 datasets with errorbars and one doesn't see them in one case, then they may think that the uncertainties are very small. @jenniferyee What do you think?

rpoleski commented 1 year ago

Option 1. chosen. Issue solved in 7bcac6c.