bugs in example 16 - Githubissues

rpoleski / MulensModel

Microlensing Modelling package

https://rpoleski.github.io/MulensModel/

Other

57 stars 15 forks source link

bugs in example 16 #93

Open rpoleski opened 1 year ago

rpoleski commented 1 year ago

[ ] Delta t_0 is not saved anywhere

Things that are borderline between bug and missing enhancement:

[ ] print script version
[ ] save fixed parameters
[ ] warnings if plots will overwrite existing files

rapoliveira commented 1 year ago

@rpoleski I have addressed all the bugs/improvements listed here. Moreover, I added a boolean option to the yaml input file, under "second Y axis" of the best model plot, in order to recalculate the magnifications if the provided list is out of range.

Please take a look at it and send any suggestions before I make the pull request.

rpoleski commented 1 year ago

Nice job! I would suggest one change. You added a new option recalculate magnification ticks. There will be a problem if the user provides both that and magnifications: which one should be used? I would suggest not to add that option, but instead allow, e.g., magnifications: optimal. And second thing (sic!) - if optimal is provided, then labels are not allowed.