Suggestions

[mikesalz]

Hi @rsampayo - So far this integration is working very well! I have a few questions/suggestions. I'm not going to pretend to know python very well, but if I am reading the code correctly it looks like the model and firmware version might be hard coded. I am wondering if the API can be used to get that data? There are some other informational fields available as well, like serial number, IP address, temperature unit, time zone, etc. Those are really just "nice to haves" but wouldn't have any impact on functionality.

[rsampayo]

Hey Mike, I like your attention to detail. That's correct. They are only a placeholder. Let me see what I can do.

[rsampayo]

I am going to try to add Firmware, mac, model and serial number to the device info. And then I might add IP, LAN IP, is_connected, timezone, brightness_level and display_temp_unit a sensors in a Diagnostic section.

[mikesalz]

I like your attention to detail

I think this translates to: I wish this guy would just leave me alone! :)

[rsampayo]

I like your attention to detail

I think this translates to: I wish this guy would just leave me alone! :)

Hahah, not at all. The complete opposite! Keep them coming. Just help me out with the testing.

[mikesalz]

You got it!

[rsampayo]

Ok Mike, give it a go.

[mikesalz]

hmmm... I downloaded the current code, deleted my sleepme_thermostat folder from custom_components, and then copied the new folder into it and restarted HA. Twice. But none of the new info is showing. I even verified that the values are in the python. Interestingly, the model and firmware version are now completely gone from the Device Info section. And I am not seeing any errors in the logs.

[rsampayo]

Can you delete your devices restart and re add. And turn on "debug log" and check the full log to see if you get errors.

[mikesalz]

Looking better!

[mikesalz]

Also - You may have already seen this in your research, but I found this page that discusses how to add logos.

https://developers.home-assistant.io/blog/2020/05/08/logos-custom-integrations/

[rsampayo]

Also - You may have already seen this in your research, but I found this page that discusses how to add logos.

https://developers.home-assistant.io/blog/2020/05/08/logos-custom-integrations/

Thats great, do you think you could create the icons with the needed specs?

[mikesalz]

I can give it a shot over the weekend

[rsampayo]

I can give it a shot over the weekend

Great, you pick the look.

[rsampayo]

I created an issue for the icon https://github.com/rsampayo/sleepme_thermostat/issues/2