search

rsanchezsaez / CardboardSDK-iOS

iOS port of Google's CardboardSDK (mobile VR toolkit)
Other
334 stars 104 forks source link

can not full screen in 6 plus/6s plus #23

Open ljfdestiny opened 8 years ago

ljfdestiny commented 8 years ago

When using 6 plus and 6s plus(Device) render in VR mode can not full screen, any idea of it?

ericgouldbear commented 8 years ago

We've found a similar problem and would appreciate some guidance in solving. In our publicly-available app, Walk-in Theater, iPhone 6+ draws VR mode fine, utilizing full height and width of the screen. iPhone 6S+, however, draws eyeFrames in a smaller region of the screen -- as if it is a 6/6S-sized screen inside a 6S+. There is extra black above and to the left and right of the eyeFrames. No problem drawing to the rest of the screen outside CardboardSDK-iOS, as you can see from compass in bottom-left of 6S+ screenshot below.

Anyone else getting this result? Would love some creative suggestions on how to open those eyes up to the full screen on 6S+ to match 6+ experience. Thanks!

iPhone 6S+: img_0717

iPhone 6+: img_8186

rsanchezsaez commented 8 years ago

I think you need to add the iPhone 6s, iPhone 6s+ and iPhone SE product codes to this list. It'd be good to take the chance and add all the new iPads too.

Also, double check that these two macros continue to work with the iPhone 6s+.

Can somebody check if this fixes the problem? If it does, I'll be glad to accept a PR.