rsjudka / intelligent-auto

41 stars 15 forks source link

API Function, GPIO functionality #22

Open rhysmorgan134 opened 4 years ago

rhysmorgan134 commented 4 years ago

Built this today, and had a play. Loving it so far, the UI is gorgeous.

A couple of bits I would love to see

Thanks for the great project!

rsjudka commented 4 years ago

1) finalizing the changes for the custom app tab as we speak. To make the integration as straightforward as possible, however, I need to launch the program within my app so I can control the window and whatnot. I am including a toggle for enabling the custom app to be launched when my app launches. Does that work for you?

2) I could look into adding some sort of "action mapping" where you can configure various actions (like keystrokes, gpio, etc) to do something in the app (like open different tabs and stuff).

3) This should be easy enough. Will most likely add a config option for hiding it.

4) Ah yes definitely a big one. From what we talked about previously, the main issues with this would be getting the actual data in my app. Off the top of my head I would think maybe opening up a socket and allowing data to be sent/received through it might work? Will definitely have to ponder this a lot more tho. And definitely think it would need to be implemented as some sort of plugin since it would need to be highly customizable.

rhysmorgan134 commented 4 years ago
  1. Sounds like it will work, I think we are talking about the same process. I just do it like that so the app doesnt "launch" everytime its opened as that takes a while, instead its just brought to foreground

  2. sounds good.

  3. sounds good.

  4. Socket certainly sounds a decent way to go, may be worth looking into mqtt aswell as thats pretty lightweight. Just initial thinking from my end, perhaps having an icon library such as material.io, and then the message can just contain icon name and value

{ "icon": "ac_unit", "value": 24, "units": "degrees" }

https://material.io/resources/icons/?style=baseline

unfortunately my C++ skills are non existent so I can't help a great deal. But if the app integration goes well then the language won't be such a big factor, I have a pretty cool obd app on the way.

Also if you need anything to test integration into your system let me know I can whip things up pretty quick.

rsjudka commented 4 years ago

If you want to start using the custom apps tab, feel free to start using the app-launcher branch. Just as a warning, it's still somewhat experimental and you may need to customize it a bit to work for your needs.

The biggest pain point I've been finding is that some apps take longer to launch than others, and qt might try embedding the app before its fully launched.

Let me know how this works for you, and if you notice something seems broken (I've testing on a few apps I have on my system but what you might be using could behave differently) let me know and I can walk you through some possible workarounds.

rsjudka commented 4 years ago

Just initial thinking from my end, perhaps having an icon library such as material.io, and then the message can just contain icon name and value

material.io is the best haha use it exclusively for all my icons

idk if I would want to include the entire library tho, and since they're all svgs and super small that's probably something that could just be sent from an endpoint and constructed at runtime (I think).

I'm kinda imagining something where the endpoint would first send some "configuration" messages to setup the various UI elements, and then data could just be freely updated as it changes

rsjudka commented 4 years ago

I have a branch config-controls for hiding the volume slider (changed with the intentions of enabling you to add the API functionality we were talking about in its place). You'll also get better brightness control for free :p

robert5974 commented 4 years ago

While having the latest branch of Develop (with the brightness module and quick view toggle), I thought to make a recommendation.
Could a toggle be placed next to the volume slider to toggle between brightness and volume? In settings it could be an option of the quick view. Options could be listed as:

  1. None
  2. Volume
  3. Brightness
  4. Brightness/Volume

I would like to have a slider I could toggle between vol/brightness personally but options are nice for others. Just a thought.

rsjudka commented 4 years ago

@robert5974 sounds like a good idea, will add in the near future

robert5974 commented 4 years ago

Thanks! No rush.

Robert Crowley

On Sat, May 2, 2020, 9:09 PM Robert Stanley Judka notifications@github.com wrote:

@robert5974 https://github.com/robert5974 sounds like a good idea, will add in the near future

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rsjudka/intelligent-auto/issues/22#issuecomment-623037242, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLUDVFVR35MBOH2OTUL7QDRPS723ANCNFSM4MFSRYWA .