search

rsmp-nordic / rsmp_sxl_traffic_lights

RSMP Signal Exchange List (SXL) for Traffic Controllers
MIT License
12 stars 4 forks source link

M0019: status True/False mixed up? #121

Closed otterdahl closed 2 years ago

otterdahl commented 3 years ago

The status of M0019 says "False: Force input" and "True: Release input" which is confusing.

Name Command Type Value Comment
status setInput boolean -False
-True		 False: Force input
True: Release input
otterdahl commented 3 years ago

I don't know how the TLC's has chosen to implement this. This needs to be checked before fixing this.

emiltin commented 3 years ago

i think we should change it anyways. leaving it will just cause more confusion?

otterdahl commented 3 years ago

The problem is if the TLC's has implemented this according to the current text (e.g. "True: Release input"). Then fixing this will make the new SXL not backwards compatible. Previously we have chosen to avoid breaking changes in the SXL.

emiltin commented 3 years ago

we should use the validator to check how equipment actually implement this

emiltin commented 3 years ago

our current equipment tests still run 1.0.7. we need to update the equipment (or configs) before we can run tests for M0019

otterdahl commented 2 years ago

A similar case is M0005. It says "False: Activate", which is confusing

otterdahl commented 2 years ago

Let's just fix this. Updated the draft