Tests improvements - Githubissues

rsocket / rsocket-kotlin

RSocket Kotlin multi-platform implementation

http://rsocket.io

Apache License 2.0

552 stars 37 forks source link

Closed whyoleg closed 4 years ago

whyoleg commented 4 years ago

Main goal of PR is preparation for K/N target + improving nodejs testing

Rewrite tests to use suspend before and after tests - needed for better testing of nodejs
use mocha for nodejs tests - before it was karma which is more for browser
fix some issues for nodejs IR regarding cancelling
cleanup playground + move TCP to common (for future Native)
minor: payload creation from ByteArrays
minor: change a little JS logger to not print null all time where exception is null

yschimke commented 4 years ago

Opting out - probably won't get time in next few days given a big PR

whyoleg commented 4 years ago

@yschimke @OlegDokuka any review, or I will merge it? Native support is ready and it depends on it

yschimke commented 4 years ago

No opinion. Land if it's blocking forward progress.