search

rspeer / dominiate

A simulator for Dominion card game strategies
http://rspeer.github.com/dominiate
MIT License
121 stars 43 forks source link

Courtyard holds onto money unnecessarily #53

Open rspeer opened 13 years ago

rspeer commented 13 years ago

The OBM Courtyard strategy plays far from optimally. If it has $7 in hand, for example, it doesn't seem to return a copper to its deck, even though the comments in the putOnDeckPriority say that it should.

bilts commented 12 years ago

I fixed this (see above pull request).

I was trying to find a repeatable way of testing it, since it was a pain to get the AI to trigger this condition. I ended up using cucumber-js, mostly just to take a look at that project.

I'm happy with how the feature file turned out. It seems like it has a lot of potential for Dominion, but I know the whole Cucumber/BDD thing isn't everyone's cup of tea.

I committed the experiment on a separate branch if you care to take a look: https://github.com/bilts/dominiate/tree/cucumber

npm install cucumber cucumber.js --require features/step_definitions/

The test will fail because it's branched off of master, which doesn't have the Courtyard fix yet.