search

rspeer / dominiate

A simulator for Dominion card game strategies
http://rspeer.github.com/dominiate
MIT License
121 stars 43 forks source link

Comments from pull request #55 addressed + Machine Learner Code #58

Closed Narmical closed 12 years ago

Narmical commented 12 years ago

Rspeer,

I addressed the comments that you made on pull request #55. I think i fixed them all. Also included is the current code I'm working on: Its code to machine learn dominion strategies. I'm not sure how to exclude it from the pull request the files with the machine learning are TicToc.coffee evoultionAI.coffee goEvo.coffee evaluate.coffee

rspeer commented 12 years ago

This is some really exciting code. (How well does it work? Has it discovered any successful new strategies?)

I think this code makes the most sense if it remains in a branch or fork. I don't want to merge it into the main codebase, but don't take that to mean I'm turning down the code. Basically, this is just a lot of additional code that I wouldn't be able to support if it were in the main branch.

So I think it should remain in your GitHub, because if someone wants help with it they should ask you and not me. But I will put a link in the documentation to this version.

Narmical commented 12 years ago

Thanks for the compliment and the link.

I have not gotten good results yet. Still working out the kinks. The current version is still running, the best player so far only beats big money 40% of the time.

I agree with your assessment on the merge. I really just wanted to share the updates related to fixing the command line script, but could not figure out how.

Glad you like it,

Mitch

Sent from my iPod

On Jan 26, 2012, at 3:23 AM, Rob Speer reply@reply.github.com wrote:

This is some really exciting code. (How well does it work? Has it discovered any successful new strategies?)

I think this code makes the most sense if it remains in a branch or fork. I don't want to merge it into the main codebase, but don't take that to mean I'm turning down the code. Basically, this is just a lot of additional code that I wouldn't be able to support if it were in the main branch.

So I think it should remain in your GitHub, because if someone wants help with it they should ask you and not me. But I will put a link in the documentation to this version.

Reply to this email directly or view it on GitHub: https://github.com/rspeer/dominiate/pull/58#issuecomment-3665769