search

rst-tu-dortmund / teb_local_planner

An optimal trajectory planner considering distinctive topologies for mobile robots based on Timed-Elastic-Bands (ROS Package)
http://wiki.ros.org/teb_local_planner
BSD 3-Clause "New" or "Revised" License
992 stars 546 forks source link

[ros2-mater] Sync with noetic-devel #282

Closed doisyg closed 3 years ago

doisyg commented 3 years ago

As discussed here: https://github.com/rst-tu-dortmund/teb_local_planner/issues/283 Include the PR fixing compilation: https://github.com/rst-tu-dortmund/teb_local_planner/pull/281 First part of the maintenance plan for ros2-master. Compiles and runs fine, no extensive checks done yet.

doisyg commented 3 years ago

I just very very briefly skimmed over it to make sure everything looked sane, but is there any thing else you'd like us to do before merging this backported content into ROS2-master?

Not at the moment, melodic sync will follow once this is merged.

We should probably do some minimal sanity checking that it fixed some of the issues that those PRs aimed to solve

I agree, I am planning to check the behavior of each one of the commit/PR and report in the table there: https://github.com/rst-tu-dortmund/teb_local_planner/issues/283 . But I will do it once most of the sync/merge are done. I am under the impression (from my colleagues report), that some PR were buggy or introduced some bugs already in ROS1.

SteveMacenski commented 3 years ago

But I will do it once most of the sync/merge are done. I am under the impression (from my colleagues report), that some PR were buggy or introduced some bugs already in ROS1.

Wait, so you think there are bugs this PR might be introducing from these PRs? Wouldn't we want to test them then before merging them if we feel there's a high chance of introducing issues?

doisyg commented 3 years ago

No on this PR (to the best of my knowledge), but I am expecting to have to correct few things and the fly when porting the melodic sync.