rstephan / ArtnetnodeWifi

Arduino library for a Art-Net-Node (artnet) over WiFi, handle DMX data and response to Poll requests. Runs on ESP8266, ESP32, WiFi101 and WiFiNINA devices.
82 stars 21 forks source link

Update Library Version #13

Closed soeren-helbig closed 5 years ago

soeren-helbig commented 5 years ago

Hey! I am using PlatformIO for arduino development. When i try to compile the library, i get the following error:

/home/soeren/.platformio/lib/ArtnetnodeWifi_ID1709/src/ArtnetnodeWifi.cpp: In member function 'uint8_t ArtnetnodeWifi::begin()':
/home/soeren/.platformio/lib/ArtnetnodeWifi_ID1709/src/ArtnetnodeWifi.cpp:55:40: error: ambiguous overload for 'operator~' (operand type is 'IPAddress')
   localBroadcast = IPAddress(localIP | ~localMask);
                                        ^
/home/soeren/.platformio/lib/ArtnetnodeWifi_ID1709/src/ArtnetnodeWifi.cpp:55:40: note: candidates are:
/home/soeren/.platformio/lib/ArtnetnodeWifi_ID1709/src/ArtnetnodeWifi.cpp:55:40: note: operator~(uint32_t {aka unsigned int}) <built-in>
/home/soeren/.platformio/lib/ArtnetnodeWifi_ID1709/src/ArtnetnodeWifi.cpp:55:40: note: operator~(u32_t {aka long unsigned int}) <built-in>
/home/soeren/.platformio/lib/ArtnetnodeWifi_ID1709/src/ArtnetnodeWifi.cpp:55:40: note: operator~(int) <built-in>
*** [.pio/build/oak/libf80/ArtnetnodeWifi_ID1709/ArtnetnodeWifi.cpp.o] Error 1

After diving into the commit history, i found your latest commit (3dbac9d6b4fd33225c5433a599e0eb7e6012d8c1) handles exactly this line. But in PlatformIO the latest libray version does not contain this commit. Only the second latest commit is available (6d79db8de875cdf124aaf62bf7cfd2ca9bef922a).

I am not sure about this, but for me it seems that PlatformIO only recognizes updates if the version, in library.properties, is incremented.

rstephan commented 5 years ago

Thanks for the advice.