search

rstephan / ArtnetnodeWifi

Arduino library for a Art-Net-Node (artnet) over WiFi, handle DMX data and response to Poll requests. Runs on ESP8266, ESP32, WiFi101 and WiFiNINA devices.
80 stars 20 forks source link

Fixed local broadcast address calculation and MAC address when in AP mode #23

Open alf45tar opened 1 year ago

alf45tar commented 1 year ago

Hi @rstephan, I fixed your library when using EPS8266 in AP mode. Do you want me to submit a PR?

Thanks alf45tar

rstephan commented 1 year ago

Sure, why not.

rstephan commented 1 year ago

Sorry for the delay.

I don't like the fact, that there is a hard-coded value in the code. Apart from that, it is looking good.

But you can get the CIDR with softAPSubnetCIDR() and compute the subnet mask form that.

rstephan commented 1 year ago

Maybe I can convince the Espressif folks to have a shortcut ;-)

https://github.com/espressif/arduino-esp32/pull/8358

alf45tar commented 1 year ago

Sorry for the delay.

I don't like the fact, that there is a hard-coded value in the code. Apart from that, it is looking good.

But you can get the CIDR with softAPSubnetCIDR() and compute the subnet mask form that.

Thanks for let me know the softAPSubnetCIDR(). I will use it and submit the new fix.

alf45tar commented 1 year ago

softAPSubnetCIDR() is not available for ESP8266.

alf45tar commented 1 year ago

Hard coded netmask removed in AP mode using wifi_get_ip_info(). PR ready to merge.

rstephan commented 1 year ago

Hi,

and sadly, the function wifi_get_ip_info() is not available in ESP32. Or at least not in the Arduino board package 2.0.9. So this is also not a valid solution.

My library should work with every board or at least with as many as possible. Therefore, and due to the fact that every board (ESP8266, ESP32, RP2040, ...) hast a different API for the AP-Mode, I am going into a other direction. It is not a good solution to build exceptions for all controller into my library.

I am seeing this more like this:

uint8_t ArtnetnodeWifi::begin(String hostname); // "Normal", client mode
uint8_t ArtnetnodeWifi::begin(String hostname, IPAddress ip, IPAddress netmask, IPAddress gateway);
uint8_t ArtnetnodeWifi::begin(String hostname, IPAddress ip, IPAddress netmask, IPAddress gateway, byte* mac);

You have the information during setup for the softAPConfig() function, why not using this information for the ArtnetnodeWifi::begin() call?