search

rstudio / blastula

Easily send great-looking HTML email messages from R
https://pkgs.rstudio.com/blastula
Other
548 stars 85 forks source link

Adding quillt pkgdown site built by GHA #252

Closed apreshill closed 3 years ago

apreshill commented 3 years ago

👋 @rich-iannone

Draft for now so we have something to talk about 😄

apreshill commented 3 years ago

Update: I have the Github Action working to build then deploy to Netlify.

Draft url: https://blastula-pkg.netlify.app/

We'll need to use the GH action in this PR to deploy to Netlify (no branches), so that ultimately we can add the package here: https://pkgs.rstudio.com/

And use Netlify rewrites to get you the url: https://pkgs.rstudio.com/blastula

Since there is already a GH pages link and redirects are not possible there, we'll probably want to add back in a deploy_to_branch bit in the workflow.

I did have a few build problems with 2 undocumented functions- I added them to get the build working, but perhaps not in the right place? https://github.com/apreshill/blastula/blob/3b30528da0ca64594bea70bfda3355c04941f21e/_pkgdown.yml#L40-L41

apreshill commented 3 years ago

Thank you @cderv! @rich-iannone we need to set up a time to scheme :)

rich-iannone commented 3 years ago

Thank you so much for all of this! @apreshill let's definitely talk about what else can be done here.

apreshill commented 3 years ago

@rich-iannone for consistency, can you:

  1. change "Introduction" to "Get started"?
  2. Move examples before articles?

Looks great!

apreshill commented 3 years ago

Shall we launch this thing? We'll need to update the workflow, but this URL is already working: https://pkgs.rstudio.com/blastula/

rich-iannone commented 3 years ago

YES! Let's make it happen.