rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
480 stars 57 forks source link

Nested card with full_screen makes all cards fullscreen #590

Closed mcsimenc closed 1 year ago

mcsimenc commented 1 year ago

Describe the problem

This might be the same problem as reported here: https://github.com/rstudio/bslib/issues/558, but since that issue is closed and this problem occurs with the newest version of bslib installed with remotes::install_github("rstudio/bslib"), here it is:

I also asked this on stackoverflow.com here: https://stackoverflow.com/questions/76245761/can-bslib-nested-card-fullscreen-behavior-show-just-the-nested-card/76246323#76246323

I would expect the fullscreen toggle for cards using full_screen = T to maximize just that card and not all parent cards. Is this behavior possible? Thanks!

library(shiny)
library(bslib)

ui = page(
  card(
    full_screen = F,
    card_header(
      "Main card",
    ),
    card(
      full_screen = T,
      card_header(
        "Nested card"
      ),
      plotOutput("plot")
    )
  )
)

server = function(input, output)
{
  output$plot = renderPlot(hist(rnorm(100)))
}

shinyApp(ui, server)

Session Info


> devtools::session_info()
─ Session info ───────────────────────────────────────────────────────────────────────────────────────────────────────
 setting  value
 version  R version 4.3.0 (2023-04-21)
 os       macOS Monterey 12.0.1
 system   aarch64, darwin20
 ui       RStudio
 language (EN)
 collate  en_US.UTF-8
 ctype    en_US.UTF-8
 tz       America/Los_Angeles
 date     2023-05-21
 rstudio  2023.05.0-daily+366 Mountain Hydrangea (desktop)
 pandoc   3.1.1 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/ (via rmarkdown)

─ Packages ───────────────────────────────────────────────────────────────────────────────────────────────────────────
 package          * version    date (UTC) lib source
 abind              1.4-5      2016-07-21 [1] CRAN (R 4.3.0)
 ape                5.7-1      2023-03-13 [1] CRAN (R 4.3.0)
 aplot              0.1.10     2023-03-08 [1] CRAN (R 4.3.0)
 assertthat         0.2.1      2019-03-21 [1] CRAN (R 4.3.0)
 bslib              0.4.2.9000 2023-05-21 [1] Github (rstudio/bslib@4fdc8f8)
 ca                 0.71.1     2020-01-24 [1] CRAN (R 4.3.0)
 cachem             1.0.8      2023-05-01 [1] CRAN (R 4.3.0)
 callr              3.7.3      2022-11-02 [1] CRAN (R 4.3.0)
 cli                3.6.1      2023-03-23 [1] CRAN (R 4.3.0)
 cluster            2.1.4      2022-08-22 [1] CRAN (R 4.3.0)
 codetools          0.2-19     2023-02-01 [1] CRAN (R 4.3.0)
 colorspace         2.1-0      2023-01-23 [1] CRAN (R 4.3.0)
 cowplot            1.1.1      2020-12-30 [1] CRAN (R 4.3.0)
 crayon             1.5.2      2022-09-29 [1] CRAN (R 4.3.0)
 crosstalk          1.2.0      2021-11-04 [1] CRAN (R 4.3.0)
 curl               5.0.0      2023-01-12 [1] CRAN (R 4.3.0)
 data.table         1.14.8     2023-02-17 [1] CRAN (R 4.3.0)
 data.tree        * 1.0.0      2020-08-03 [1] CRAN (R 4.3.0)
 deldir             1.0-6      2021-10-23 [1] CRAN (R 4.3.0)
 dendextend         1.17.1     2023-03-25 [1] CRAN (R 4.3.0)
 desc               1.4.2      2022-09-08 [1] CRAN (R 4.3.0)
 devtools           2.4.5      2022-10-11 [1] CRAN (R 4.3.0)
 digest             0.6.31     2022-12-11 [1] CRAN (R 4.3.0)
 dplyr            * 1.1.2      2023-04-20 [1] CRAN (R 4.3.0)
 ellipsis           0.3.2      2021-04-29 [1] CRAN (R 4.3.0)
 evaluate           0.21       2023-05-05 [1] CRAN (R 4.3.0)
 fansi              1.0.4      2023-01-22 [1] CRAN (R 4.3.0)
 farver             2.1.1      2022-07-06 [1] CRAN (R 4.3.0)
 fastmap            1.1.1      2023-02-24 [1] CRAN (R 4.3.0)
 fitdistrplus       1.1-11     2023-04-25 [1] CRAN (R 4.3.0)
 foreach            1.5.2      2022-02-02 [1] CRAN (R 4.3.0)
 fs                 1.6.2      2023-04-25 [1] CRAN (R 4.3.0)
 future             1.32.0     2023-03-07 [1] CRAN (R 4.3.0)
 future.apply       1.10.0     2022-11-05 [1] CRAN (R 4.3.0)
 generics           0.1.3      2022-07-05 [1] CRAN (R 4.3.0)
 ggfun              0.0.9      2022-11-21 [1] CRAN (R 4.3.0)
 ggplot2          * 3.4.2      2023-04-03 [1] CRAN (R 4.3.0)
 ggplotify          0.1.0      2021-09-02 [1] CRAN (R 4.3.0)
 ggrepel            0.9.3      2023-02-03 [1] CRAN (R 4.3.0)
 ggridges           0.5.4      2022-09-26 [1] CRAN (R 4.3.0)
 ggtree           * 3.7.1      2022-12-20 [1] Bioconductor
 globals            0.16.2     2022-11-21 [1] CRAN (R 4.3.0)
 glue               1.6.2      2022-02-24 [1] CRAN (R 4.3.0)
 goftest            1.2-3      2021-10-07 [1] CRAN (R 4.3.0)
 gridExtra          2.3        2017-09-09 [1] CRAN (R 4.3.0)
 gridGraphics       0.5-1      2020-12-13 [1] CRAN (R 4.3.0)
 gtable             0.3.3      2023-03-21 [1] CRAN (R 4.3.0)
 heatmaply        * 1.4.3      2023-05-17 [1] xgit (https://gitlab.com/mcsimenc/heatmaply.git@f285d09)
 htmltools        * 0.5.5      2023-03-23 [1] CRAN (R 4.3.0)
 htmlwidgets        1.6.2      2023-03-17 [1] CRAN (R 4.3.0)
 httpuv             1.6.9      2023-02-14 [1] CRAN (R 4.3.0)
 httr               1.4.5      2023-02-24 [1] CRAN (R 4.3.0)
 ica                1.0-3      2022-07-08 [1] CRAN (R 4.3.0)
 igraph             1.4.2      2023-04-07 [1] CRAN (R 4.3.0)
 irlba              2.3.5.1    2022-10-03 [1] CRAN (R 4.3.0)
 iterators          1.0.14     2022-02-05 [1] CRAN (R 4.3.0)
 jquerylib          0.1.4      2021-04-26 [1] CRAN (R 4.3.0)
 jsonlite           1.8.4      2022-12-06 [1] CRAN (R 4.3.0)
 KernSmooth         2.23-21    2023-05-03 [1] CRAN (R 4.3.0)
 knitr              1.42       2023-01-25 [1] CRAN (R 4.3.0)
 labeling           0.4.2      2020-10-20 [1] CRAN (R 4.3.0)
 later              1.3.1      2023-05-02 [1] CRAN (R 4.3.0)
 lattice            0.21-8     2023-04-05 [1] CRAN (R 4.3.0)
 lazyeval           0.2.2      2019-03-15 [1] CRAN (R 4.3.0)
 leiden             0.4.3      2022-09-10 [1] CRAN (R 4.3.0)
 lifecycle          1.0.3      2022-10-07 [1] CRAN (R 4.3.0)
 listenv            0.9.0      2022-12-16 [1] CRAN (R 4.3.0)
 lmtest             0.9-40     2022-03-21 [1] CRAN (R 4.3.0)
 magrittr         * 2.0.3      2022-03-30 [1] CRAN (R 4.3.0)
 MASS               7.3-60     2023-05-04 [1] CRAN (R 4.3.0)
 Matrix             1.5-4      2023-04-04 [1] CRAN (R 4.3.0)
 matrixStats        0.63.0     2022-11-18 [1] CRAN (R 4.3.0)
 memoise          * 2.0.1      2021-11-26 [1] CRAN (R 4.3.0)
 mime               0.12       2021-09-28 [1] CRAN (R 4.3.0)
 miniUI             0.1.1.1    2018-05-18 [1] CRAN (R 4.3.0)
 munsell            0.5.0      2018-06-12 [1] CRAN (R 4.3.0)
 nlme               3.1-162    2023-01-31 [1] CRAN (R 4.3.0)
 parallelly         1.35.0     2023-03-23 [1] CRAN (R 4.3.0)
 patchwork          1.1.2      2022-08-19 [1] CRAN (R 4.3.0)
 pbapply            1.7-0      2023-01-13 [1] CRAN (R 4.3.0)
 pbmcapply        * 1.5.1      2022-04-28 [1] CRAN (R 4.3.0)
 pillar             1.9.0      2023-03-22 [1] CRAN (R 4.3.0)
 pkgbuild           1.4.0      2022-11-27 [1] CRAN (R 4.3.0)
 pkgconfig          2.0.3      2019-09-22 [1] CRAN (R 4.3.0)
 pkgload            1.3.2      2022-11-16 [1] CRAN (R 4.3.0)
 plantan          * 0.0.0.1    2023-05-12 [1] xgit (https://gitlab.com/mcsimenc/plantan.git@abfa86f)
 plotly           * 4.10.1     2022-11-07 [1] CRAN (R 4.3.0)
 plyr               1.8.8      2022-11-11 [1] CRAN (R 4.3.0)
 png                0.1-8      2022-11-29 [1] CRAN (R 4.3.0)
 polyclip           1.10-4     2022-10-20 [1] CRAN (R 4.3.0)
 prettyunits        1.1.1      2020-01-24 [1] CRAN (R 4.3.0)
 processx           3.8.1      2023-04-18 [1] CRAN (R 4.3.0)
 profvis            0.3.8      2023-05-02 [1] CRAN (R 4.3.0)
 progressr          0.13.0     2023-01-10 [1] CRAN (R 4.3.0)
 promises           1.2.0.1    2021-02-11 [1] CRAN (R 4.3.0)
 ps                 1.7.5      2023-04-18 [1] CRAN (R 4.3.0)
 purrr              1.0.1      2023-01-10 [1] CRAN (R 4.3.0)
 R6                 2.5.1      2021-08-19 [1] CRAN (R 4.3.0)
 ragg               1.2.5      2023-01-12 [1] CRAN (R 4.3.0)
 RANN               2.6.1      2019-01-08 [1] CRAN (R 4.3.0)
 RColorBrewer     * 1.1-3      2022-04-03 [1] CRAN (R 4.3.0)
 Rcpp               1.0.10     2023-01-22 [1] CRAN (R 4.3.0)
 RcppAnnoy          0.0.20     2022-10-27 [1] CRAN (R 4.3.0)
 registry           0.5-1      2019-03-05 [1] CRAN (R 4.3.0)
 remotes            2.4.2      2021-11-30 [1] CRAN (R 4.3.0)
 reshape2           1.4.4      2020-04-09 [1] CRAN (R 4.3.0)
 reticulate         1.28       2023-01-27 [1] CRAN (R 4.3.0)
 rlang              1.1.1      2023-04-28 [1] CRAN (R 4.3.0)
 rmarkdown          2.21       2023-03-26 [1] CRAN (R 4.3.0)
 ROCR               1.0-11     2020-05-02 [1] CRAN (R 4.3.0)
 rprojroot          2.0.3      2022-04-02 [1] CRAN (R 4.3.0)
 rstudioapi         0.14       2022-08-22 [1] CRAN (R 4.3.0)
 Rtsne              0.16       2022-04-17 [1] CRAN (R 4.3.0)
 sass               0.4.6      2023-05-03 [1] CRAN (R 4.3.0)
 scales             1.2.1      2022-08-20 [1] CRAN (R 4.3.0)
 scattermore        1.0        2023-05-03 [1] CRAN (R 4.3.0)
 sctransform        0.3.5      2022-09-21 [1] CRAN (R 4.3.0)
 seriation          1.4.2      2023-03-08 [1] CRAN (R 4.3.0)
 sessioninfo        1.2.2      2021-12-06 [1] CRAN (R 4.3.0)
 Seurat           * 4.3.0      2022-11-18 [1] CRAN (R 4.3.0)
 SeuratObject     * 4.1.3      2022-11-07 [1] CRAN (R 4.3.0)
 shiny            * 1.7.4      2022-12-15 [1] CRAN (R 4.3.0)
 shinydashboard   * 0.7.2      2021-09-30 [1] CRAN (R 4.3.0)
 shinyjs          * 2.1.0      2021-12-23 [1] CRAN (R 4.3.0)
 shinyThings      * 0.4.0      2023-05-14 [1] Github (gadenbuie/shinyThings@585a40f)
 sp                 1.6-0      2023-01-19 [1] CRAN (R 4.3.0)
 spatstat.data      3.0-1      2023-03-12 [1] CRAN (R 4.3.0)
 spatstat.explore   3.1-0      2023-03-14 [1] CRAN (R 4.3.0)
 spatstat.geom      3.1-0      2023-03-12 [1] CRAN (R 4.3.0)
 spatstat.random    3.1-4      2023-03-13 [1] CRAN (R 4.3.0)
 spatstat.sparse    3.0-1      2023-03-12 [1] CRAN (R 4.3.0)
 spatstat.utils     3.0-2      2023-03-11 [1] CRAN (R 4.3.0)
 stringi            1.7.12     2023-01-11 [1] CRAN (R 4.3.0)
 stringr          * 1.5.0      2022-12-02 [1] CRAN (R 4.3.0)
 survival           3.5-5      2023-03-12 [1] CRAN (R 4.3.0)
 systemfonts        1.0.4      2022-02-11 [1] CRAN (R 4.3.0)
 tensor             1.5        2012-05-05 [1] CRAN (R 4.3.0)
 textshaping        0.3.6      2021-10-13 [1] CRAN (R 4.3.0)
 tibble             3.2.1      2023-03-20 [1] CRAN (R 4.3.0)
 tidyr              1.3.0      2023-01-24 [1] CRAN (R 4.3.0)
 tidyselect         1.2.0      2022-10-10 [1] CRAN (R 4.3.0)
 tidytree           0.4.2      2022-12-18 [1] CRAN (R 4.3.0)
 treeio           * 1.23.1     2023-03-24 [1] Bioconductor
 TSP                1.2-4      2023-04-04 [1] CRAN (R 4.3.0)
 urlchecker         1.0.1      2021-11-30 [1] CRAN (R 4.3.0)
 usethis            2.1.6      2022-05-25 [1] CRAN (R 4.3.0)
 utf8               1.2.3      2023-01-31 [1] CRAN (R 4.3.0)
 uwot               0.1.14     2022-08-22 [1] CRAN (R 4.3.0)
 vctrs              0.6.2      2023-04-19 [1] CRAN (R 4.3.0)
 viridis          * 0.6.3      2023-05-03 [1] CRAN (R 4.3.0)
 viridisLite      * 0.4.2      2023-05-02 [1] CRAN (R 4.3.0)
 webshot            0.5.4      2022-09-26 [1] CRAN (R 4.3.0)
 withr              2.5.0      2022-03-03 [1] CRAN (R 4.3.0)
 xfun               0.39       2023-04-20 [1] CRAN (R 4.3.0)
 xtable             1.8-4      2019-04-21 [1] CRAN (R 4.3.0)
 yaml               2.3.7      2023-01-23 [1] CRAN (R 4.3.0)
 yulab.utils        0.0.6      2022-12-20 [1] CRAN (R 4.3.0)
 zoo                1.8-12     2023-04-13 [1] CRAN (R 4.3.0)

 [1] /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library
mcsimenc commented 1 year ago

I must have needed to restart my RStudio to get it to work. It works now!

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you believe you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue.