search

rstudio / hex-stickers

RStudio hex stickers
Creative Commons Zero v1.0 Universal
470 stars 129 forks source link

Use a two step process on fork: render manually using a pr comment #66

Closed cderv closed 3 years ago

cderv commented 3 years ago

This should close #65

Issue is that pr-* action won't work for pull request triggered from fork.

What I suggest here is to use them as pr command - the action would fail with a message on fork, and then a render could be trigger using /render comment on a PR comment. I believe this will work as this is how the pr-* actions are used usually (as issue comment)

This involves a manual step but it is a simple addition to the current workflow.

Does it seems ok ?

I tested quickly in a fork but it is not easy to test. If it seems ok to you, I'll merge and tweak live with the current opened PRs.

cderv commented 3 years ago

I think this should do it. I am going to merge anyway and we could revise later.

hadley commented 3 years ago

Sounds good to me — feel free to just fix anything you find that's broken. I'll try to review if I can but (a) I'm deep in another project right now and (b) I clearly never understood the process very well anyway 😆.