search

rstudio / tfdatasets

R interface to TensorFlow Datasets API
https://tensorflow.rstudio.com/tools/tfdatasets/
34 stars 12 forks source link

add simple tests to check for dataset fitting with keras #28

Closed skeydan closed 5 years ago

skeydan commented 5 years ago

The newly added tests would run fine if they were in package keras, but still fail here for reasons to be investigated (I'll continue to document here as it doesn't seem to be straightforward, which is why I'm creating the PR already.)

There are 2 other tests failing since yesterday's switch to TF 1.13, which I'll investigate next.

The remaining 2 failing tests are the unrelated ones we already know about.

skeydan commented 5 years ago

Tests run fine locally but not on travis (don't yet see why).

skeydan commented 5 years ago

I've reverted to using Python 2.7 everywhere to disentangle TF testing with Python issues (it's not straightforward to make travis use Python 3 it seems).

I suggest merging this now (as after adding rstudio/keras to remotes the stable 1.13 tests now work on travis as well as "my machine") :-)

Then we could handle the Python 3 install/usage in another PR...

Just as an additional remark, there are again tests failing against 2.0 preview as I updated the preview URL so we'll also need to fix these, but this will happen all the time now I guess so we can "batch things" and periodically clean up for 2.0.