rsyslog / liblognorm

a fast samples-based log normalization library
http://www.liblognorm.com
GNU Lesser General Public License v2.1
99 stars 64 forks source link

Dev #345

Closed jjourdin closed 2 years ago

rgerhards commented 2 years ago

@jjourdin I think it would make sense to squash the commits into a few as many of them look like in-the-process-local-fixes and clutter the commit history

rgerhards commented 2 years ago

I will also need to check if CI has some defects - may very well be! In any case, thx for the PR!

rgerhards commented 2 years ago

sry, accidentally set PR to draft - have reverted

frikilax commented 2 years ago

This PR concentrates 4 different features/bug fixes, that I opened in separate PRs (or were already open) :

I think it would be simpler for anyone to try and integrate each of these PRs instead of this monolithic one

rgerhards commented 2 years ago

I think it would be simpler for anyone to try and integrate each of these PRs instead of this monolithic one

wouldn't it be possible to split them up in one commit per fix/feature?

frikilax commented 2 years ago

I think it would be simpler for anyone to try and integrate each of these PRs instead of this monolithic one

wouldn't it be possible to split them up in one commit per fix/feature?

I think this PR is now obsolete in favor of the 4 others, I will check the squash in the oldest ones but I think every PR ought to be correctly squashed

rgerhards commented 2 years ago

I think this PR is now obsolete in favor of the 4 others,

ah! sry, I hadn't notice all of them -- that of course makes sense. Feel free to close this one here whenever ready!

rgerhards commented 2 years ago

mmmhhh - I only see two - am I lost? ;-)

frikilax commented 2 years ago

mmmhhh - I only see two - am I lost? ;-)

The 2 new ones are #351 and #352.

In addition there are 2 currently open (but older) PRs also related to the changes present here : #325 and #335

frikilax commented 2 years ago

@jjourdin can we close this PR ? all related changes have been proposed as separate PRs (#351, #352, #325 and #335)

jjourdin commented 2 years ago

Job's done, thank you