Closed Splines closed 4 months ago
Once you have addressed the comments, please squash the commits into one.
Thanks for your review. I addressed all your points.
Note that I ran bundle exec rake default
again and 8 examples failed in rspec. After that, I executed the command again and now everything is passing and RuboCop did not detect any offenses. After yet another execution of that command, still everything works as expected ;)
Thanks!
When I first read about the
Performance/MapCompact
cop, I didn't understand the following sentence at first glance:that
in this sentence is confusing me grammatically-wise.filter_map
as well (see the Ruby docs). Compare that withcompact
, which only gets rid ofnil
values.This fixes #280. The issue was already closed, however, it "fixes" it in the sense that the underlying confusion should be mitigated by a better wording in the docs.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists). -> ⚠ I've included the related issue it in the PR message as well as in the changelog entry. I forgot to add it to the commit message itself, hope that's ok.master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.🛑 As a sidenote: Note that in the last checklist item, you're linking to the contribution guide of rubocop (via the changelog entry format link), not that of this repo.