Closed simsicon closed 11 years ago
Hi, I second this pull request.
@simsicon thank you for your patch. Could you please update the patch to avoid changes in the .gitignore
and .gemspec
file?
Also, I would really appreciate if you can provide a test for it.
Thank you for your contributions!
Thanks for your suggestion. Since the code is pretty obvious and I am not sure how to test it, I might just skip it, hope it's alright to you! Thanks.
Unfortunately, I need to make sure every bug is properly tested. The library is already very poor in testing and the best way to reach a reasonable testing suite is to start with patches.
The way to test is pretty simple. First, every public method should have a test, even if obvious. Second, another test should reproduce the bug (aka the exception) and fail. Once the method is created, the test should pass.
I appreciate the way, I will try to implement tests later.
Thanks! Feel free to ask me if you should have any question. I'm now maintaining several gems and, unfortunately, I'm running out of time, otherwise I would have contributed to the test on my own.
Thanks again for your cooperation.
Thanks for your opinion, the latest commit hope will do.
Bump
Got into this as well. Any ETA, @weppos? @simsicon's stuff works for me.
I'm currently experiencing a really busy period.
I'm trying to schedule one day to review all the pull requests associated to the projects I maintain. I hope this day will arrive soon.
Also hit this. Anyone have suggestions on an alternative library which can query CNAME, MX values?
I am seeing this as well.
same here..... going to be pulled?
Merged, thank you!
Thank you!!!
:sunglasses: finally! Thank you.
when trying to new a resolver,
like,
will cause a error
that's because this commit added source_address_inet6 as option but forget to implement a reader, when method "state" in resolver trying to run the following
this error will be caused.
and also bump the version to 7.2.
thanks.