ruby-ldap / ruby-net-ldap

Pure Ruby LDAP library
https://rubygems.org/gems/net-ldap
Other
399 stars 253 forks source link

Request to Add ostruct as a Dependency in net-ldap #431

Closed Ivanov-Anton closed 1 month ago

Ivanov-Anton commented 1 month ago

Background:

With the release of Ruby 3.3.5, users are now receiving warnings when using libraries that utilize ostruct without explicitly declaring it as a dependency in their gemspec. This change highlights the need for better clarity on dependencies and may lead to confusion among users regarding the operational aspects of the net-ldap gem.

The current version of net-ldap (0.19.0) does not include ostruct in its gemspec file, which can cause warning messages when used in Ruby environments upgraded to version 3.3.5 or later.

Proposed Change:

I recommend reaching out to the maintainers of net-ldap to request that they add ostruct as a dependency in the gemspec. This addition would help prevent warnings for users while ensuring clear communication regarding the required components of the library.

Example Implementation:

In the net-ldap.gemspec file, adding the following line would suffice:

s.add_dependency("ostruct")