Throw an exception when wrapper is not available at addKeepAlive

ruby-rice / rice

Ruby Interface for C++ Extensions

http://ruby-rice.github.io/

Other

370 stars 62 forks source link

Throw an exception when wrapper is not available at addKeepAlive #194

Closed maxirmx closed 9 months ago

maxirmx commented 9 months ago

Adresses https://github.com/jasonroelofs/rice/issues/193

cc: @ronaldtse

This is a contribution from Metanorma (GitHub), a product of Ribose (GitHub).

jasonroelofs commented 9 months ago

This is probably ok. Only ask would be to expand on the error message to provide some more guidance. Something like "did you use keepAlive() on a method that returns a Rice-owned type?"

maxirmx commented 9 months ago

Done

jasonroelofs commented 9 months ago

Awesome. Thanks for diving into this!