search

ruby / curses

Ruby binding for curses, ncurses, and PDCurses. Formerly part of the ruby standard library.
Other
297 stars 34 forks source link

Improve code samples #15

Closed stomar closed 7 years ago

stomar commented 9 years ago

Major revision of code samples:

All samples tested with Ruby 2.2.

drbrain commented 8 years ago

I like these improvements.

You could also swap the ARGV code for ARGF and simplify, but I'm unsure if that would be helpful for new rubyists

stomar commented 8 years ago

I only split the assignments in the basic example, not in the more elaborate ones. ok?

I essentially never use ARGF, so I'm not sure about it; but do feel free to change as you like :)

stomar commented 8 years ago

(Travis CI seems to be broken since a couple of builds...)

drbrain commented 8 years ago

Travis seems to be missing a library now, I'll check it later and merge

I'll look at switching to ARGF then.

Thanks for your work!

stomar commented 8 years ago

@drbrain This PR is almost a year old, and you essentially already approved. Could you please merge? I'd like to get this off my list.

PS. The last commit certainly is not to blame for the failing CI.

shugo commented 7 years ago

@stomar I've merged your pull request. Thanks for your contribution!

stomar commented 7 years ago

@shugo Thanks! And nice to see this is still maintained and improved.