Closed tompng closed 3 weeks ago
I think there is room for discussion whether to keep symbol completion or to drop it.
If we're going to keep it, we need to do this bsearch because symbol filtering (main bottleneck in IRB side) is few times slower than Symbol.all_symbols
.
In the following situation, Symbol.all_symbol.sort
takes about a second. I think it is not acceptable.
Symbol.all_symbols.size is 100000 with average symbol length=15 (About the number in Rails app) Running in docker (host and image platform mismatch)
Make symbol completion faster
Symbol.all_symbols.sort
and reuse it.Completion candidates of symbol contains first 50 + last 50 symbols matched to the completion target.