Fix irb_history saved to current directory - Githubissues

ruby / irb

interactive Ruby

BSD 2-Clause "Simplified" License

393 stars 119 forks source link

Fix irb_history saved to current directory #901

Closed tompng closed 8 months ago

tompng commented 8 months ago

Fixes #674 with refactoring

IRB.rc_files is used for irbrc searching and irb_history searching. I think two separate logic is combined into one and making the code complicated.

Changes

Split IRB.rc_files(ext) to IRB.irb_files and IRB.rc_file(ext)
history will be saved to dirname(ENV['IRBRC']), ENV['XDG_CONFIG_HOME'] or ENV['HOME']
IRB.conf[:RC_NAME_GENERATOR] is removed because it's impossible to configure before loading irbrc
Fix irbrc loaded twice bug mentioned in https://github.com/ruby/irb/issues/674#issuecomment-1994482350

tompng commented 8 months ago

I think IRB.conf[: RC_NAME_GENERATOR] is already changed from Proc to Array and released as v1.12.0