search

rubycas / rubycas-client

Ruby client for Yale's Central Authentication Service protocol -- an open source enterprise single sign on system for web applications.
http://code.google.com/p/rubycas-client/
Other
332 stars 217 forks source link

use Net::HTTP::Proxy and allow configuration of the proxy host and proxy port #24

Closed shevaun closed 12 years ago

shevaun commented 12 years ago

Adds configuration options for proxy_host and proxy_port, and uses Net::HTTP::Proxy instead of Net::HTTP so that it works for apps that are behind a proxy server

soupmatt commented 12 years ago

Your patch look like it will break the client in the case where you are not using a proxy server.

shevaun commented 12 years ago

It doesn't because if @proxy_host is nil, Net::HTTP::Proxy returns an instance of Net::HTTP. See http://ruby-doc.org/stdlib-1.9.3/libdoc/net/http/rdoc/Net/HTTP.html#method-c-Proxy

soupmatt commented 12 years ago

Great. The last thing I'll needs tests. I'm trying to get the test coverage up on the project. If you don't feel comfortable doing that or don't have the time, I understand, but the patch will have to wait until I have time to do it then.

On Nov 11, 2011, at 10:34 PM, Shevaun Ryan reply@reply.github.com wrote:

It doesn't because if @proxy_host is nil, Net::HTTP::Proxy returns an instance of Net::HTTP. See http://ruby-doc.org/stdlib-1.9.3/libdoc/net/http/rdoc/Net/HTTP.html#method-c-Proxy

Reply to this email directly or view it on GitHub: https://github.com/rubycas/rubycas-client/pull/24#issuecomment-2715896