use Net::HTTP::Proxy and allow configuration of the proxy host and proxy port (refactored with tests)

rubycas / rubycas-client

Ruby client for Yale's Central Authentication Service protocol -- an open source enterprise single sign on system for web applications.

http://code.google.com/p/rubycas-client/

Other

332 stars 217 forks source link

use Net::HTTP::Proxy and allow configuration of the proxy host and proxy port (refactored with tests) #36

Closed shevaun closed 12 years ago

shevaun commented 12 years ago

Adds configuration options for proxy_host and proxy_port, and uses Net::HTTP::Proxy instead of Net::HTTP so that it works for apps that are behind a proxy server. If @proxy_host is nil, Net::HTTP::Proxy returns an instance of Net::HTTP (see http://ruby-doc.org/stdlib-1.9.3/libdoc/net/http/rdoc/Net/HTTP.html#method-c-Proxy).

This pull request replaces my original one, as that was using a much older version of the gem, and didn't have tests.

soupmatt commented 12 years ago

Great! One question to save some time. Did you check your tests under 1.8.7, 1.9.2 and 1.9.3? If you did great, if not, I'll have to take some time to check that before I merge.

shevaun commented 12 years ago

I have now :) I've tested that they pass under 1.8.7-p357, 1.9.2-p290 & 1.9.3-p0.

soupmatt commented 12 years ago

sweet, thx.