rubyonjets / jets

Ruby on Jets
http://rubyonjets.com
MIT License
2.6k stars 181 forks source link

Fix webpacker upgrade issues: jets build fails for new project #215

Closed undefinedvalue closed 5 years ago

undefinedvalue commented 5 years ago

Checklist

My Environment

Software Version
Operating System OSX 10.13.4
Jets 1.8.8
Ruby 2.5.3

Expected Behaviour

A newly created Jets project should build successfully.

Current Behavior

A newly created Jets project fails to build due to webpack errors.

Here is the output of jets build err.txt

Step-by-step reproduction instructions

gem install jets
nvm install 8.10.0
nvm alias default node
npm install -g yarn
jets new --no-database demo
cd demo
jets build
tongueroo commented 5 years ago

@undefinedvalue Thanks for the report. This was an important one. Release fix in v1.8.9

Had to dig into this one a bit. Some notes for posterity:

Big thanks to: https://github.com/babel/babel-upgrade for helping with the fix.

Pushed out a release to fix this quickly. Would like to revisit the tongueroo/webpacker fork for Jets and release it as a separate gem when got time. Unsure when. Will consider PRs.