GitHub Actions tests too often

rubys / nokogumbo

A Nokogiri interface to the Gumbo HTML5 parser.

Apache License 2.0

186 stars 114 forks source link

GitHub Actions tests too often #168

Closed stevecheckoway closed 3 years ago

stevecheckoway commented 3 years ago

The current GitHub Actions setup (which was mostly copied from somewhere else) builds and tests twice when pull requests are created. I think the behavior we want is to build/test once for each

push to master;
creation of a pull request; and
push to a pull request branch other than the first.

After skimming this, it's not obvious to me if it's possible or not possible.

flavorjones commented 3 years ago

I think I've fixed this with the most recent commit on #167

stevecheckoway commented 3 years ago

Will that still build on a push to a pull request branch? In other words, when a PR is opened, it will build. But if a change is made to the PR and then pushed, will that build again?

flavorjones commented 3 years ago

:thinking: Let me test that.

flavorjones commented 3 years ago

@stevecheckoway You were right, they weren't being re-triggered. BRB, going to fix Nokogiri's Actions config.

stevecheckoway commented 3 years ago

That's too bad. There's probably a way to work around it, but it seems like something GitHub needs to fix.

flavorjones commented 3 years ago

@stevecheckoway Ah, found a thing that works, see https://github.com/rubys/nokogumbo/pull/167/commits/a7ca22b757f61f3e0d8e274864665e4c09343029