feat: add optional additional labels to resources

bdashrad commented 1 year ago

Description of the change

Allow adding arbitrary labels to different resources in the chart. Useful for monitoring and other things, and fairly common. I followed example code from the ingress-nginx and argo-cd charts.

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

bdashrad commented 1 year ago

@rahulkumark

service account and telegraf sidecar aren't configured to use common labels.

I didn't add additional labels to the service account, but will push that change now.

Telegraf sidecar is a container added to the pod, so it still gets pod labels specified above.

Common labels are also not configured on postgres sub-chart resources.

The postgres chart is a copy of the bitnami postgresql chart, embedded in the repo, and already supports adding extra labels (I add them on our own deployment here: https://github.com/rudderlabs/rudderstack-helm/blob/master/charts/postgresql/values.yaml#L296)

Instead of adding a new commonLabels section to the postgres chart, I'd prefer to see the chart use https://helm.sh/docs/helm/helm_dependency/ in Chart.yaml, pointing to the actual upstream chart instead of copying it's contents into charts/. This means not having to maintain a separate copy of this upstream chart, and ensuring we get bug fixes instead of relying on manual updates.

bdashrad commented 10 months ago

Hello! Looking for an update here 😄

gitcommitshow commented 9 months ago

Thanks Brad for the contribution and the followup. I am discussing with the team about how to move this one forward. Will get back to you.

rudderlabs / rudderstack-helm