Phoenotopia - Multiple issues

Kz-92 commented 1 year ago

Describe the bug

https://user-images.githubusercontent.com/103858019/213604214-82cc8887-20e6-4e06-87bb-fa26d7543e43.mp4

This is how Phoenotopia should play (flash player 32)

https://user-images.githubusercontent.com/103858019/213604329-acae5154-73e7-4474-b1c7-587977555c6a.mp4

This is how Phoenotopia plays on Ruffle 2023-01-19 (blink and you'll miss it)

On the Desktop version of Ruffle, there is no log, strangely enough On the Web version of Ruffle, this is the log:

WARN core/src/avm2/globals/flash/system/security.rs:41 Security.loadPolicyFile not implemented ruffle_web-wasm_extensions.js:671:20
WARN core/src/avm2/globals/toplevel.rs:42 LocalConnection.connect is not implemented ruffle_web-wasm_extensions.js:671:20
WARN core/src/avm2/globals/toplevel.rs:42 URLRequest.data setter is not yet implemented ruffle_web-wasm_extensions.js:671:20
WebGL warning: getSyncParameter: ClientWaitSync must return TIMEOUT_EXPIRED until control has returned to the user agent's main loop. (only warns once) 31
After reporting 32, no further warnings will be reported for this WebGL context.
WARN core/src/player.rs:591 AVM2 Context menu callbacks are not implemented

to reproduce the issue, just load the Phoenotopia SWF https://farm.maxgames.com/phoenotopiaMjI1Mw==.swf

Expected behavior

The game should load to the main menu and be playable.

Affected platform

Desktop app

Operating system

Windows 10

Browser

Mozilla Firefox

Additional information

No response

ActionWavele commented 1 year ago

wow, that save file, did you beat the game?

Kz-92 commented 1 year ago

Yes, I did! 😄

Lord-McSweeney commented 1 year ago

Needs unescape.

waspennator commented 1 year ago

~~Even with unescape implemented, ruffle still tosses this up in the logs as of the latest nightly.~~

Error dispatching event EventObject(EventObject { type: "commandComplete", class: com.newgrounds::APIEvent, ptr: 0x220da80 }) to handler FunctionObject(FunctionObject { ptr: 0x1d2d178 }) : RustError("Property does not exist: Multiname { ns: Single(Namespace(Namespace(\"\"))), name: Some(\"unescape\"), params: [], flags: (empty) }")

UPDATE: Retested again cause i'm assuming my browser didn't auto update to the latest build, it now seems to load to a blank preloader which causes ruffle to crash if I left click.

Lord-McSweeney commented 1 year ago

The panic message is Stage must always have a root movie.

Dinnerbone commented 1 year ago

After #10026 the error is: ReferenceError: Error #1069: Property parent not found on String and there is no default value. at LevelManager/_HandleTileMaps() at LevelManager/_LoadLevel() at LevelManager/LoadLevel() at GameWorld/_StartGame() at GameWorld/begin() at net.flashpunk::Engine/checkWorld() at net.flashpunk::Engine/update() at net.flashpunk::Engine/onEnterFrame()

Kz-92 commented 1 year ago

getting closer, kinda flash

https://user-images.githubusercontent.com/103858019/224852889-a7f9526b-17ed-4e9f-a04f-40e6a8eec254.mp4

Ruffle

https://user-images.githubusercontent.com/103858019/224852914-6ab4c3d5-fd18-469c-b059-02ae9d4a770c.mp4

Kz-92 commented 1 year ago

Flash:

https://user-images.githubusercontent.com/103858019/226206374-7a9c930a-2cb7-4a72-b6c4-ecd3d36f9b54.mp4

The game can now load the Menu!! Unfortunately, making a new save game just results a black screen, no cutscene, where clicking any button eventually kills you. Inventory and pause work, though.

Ruffle:

https://user-images.githubusercontent.com/103858019/226206359-bdacb4bc-74a4-4a43-b164-1a5a3a0fc2b6.mp4

log has ERROR ruffle_core::avm2::events: Error dispatching event EventObject(EventObject { type: "enterFrame", class: flash.events::Event, ptr: 0x1fccd9319a0 }) to handler FunctionObject(FunctionObject { ptr: 0x1fcaf73bfc0 }) : ReferenceError: Error #1069: Property parent not found on String and there is no default value.

evilpie commented 1 year ago

The loading screen looks wrong compared to Flash and never seems to progress unless I click on newground at the bottom. After starting a new game I just see a black screen and the beating hard in the top left corner. The following error gets logged:

2023-03-20T16:52:57.632455Z ERROR ruffle_core::avm2::events: Error dispatching event EventObject(EventObject { type: "enterFrame", class: flash.events::Event, ptr: 0x55e18ba9f560 }) to handler FunctionObject(FunctionObject { ptr: 0x55e18b7da810 }) : Error: Error #2058: There was an error decompressing the data.
    at flash.utils::ByteArray/flash::utils::ByteArray::uncompress()
    at LevelManager$/base64ToArray()
    at LevelManager/_HandleTileMaps()
    at LevelManager/_LoadLevel()
    at LevelManager/LoadLevel()
    at GameWorld/_StartGame()
    at GameWorld/begin()
    at net.flashpunk::Engine/checkWorld()
    at net.flashpunk::Engine/update()
    at net.flashpunk::Engine/onEnterFrame()

ActionWavele commented 1 year ago

seems like you repeated the earlier info

yoganlava commented 1 year ago

Seems to be because the newlines and whitespace are not being trimmed when constructing an XML object. Our level data node, containing the level in base64, starts with "\n " and ends with "\n " but flash seems to automatically trims the start and end when constructing the XML object. Ruffle preserves the start and ends, however, resulting in an invalid base64 string.

Example:

var test = <a>
foo
</a>;
trace(test.toXMLString());
trace(test.toString());

Ruffle:

<a>
foo
</a>

foo

Flash:

<a>foo</a>
foo

Kz-92 commented 1 year ago

the game now works! unfortunately, now that it does, a lot more issues are now revealed when the game starts, the music and sound effects are mostly normal, until the music needs to loop. once it should, most sounds and all music stop. if you save and close the game, then load your save, the music and sfx return until the next loop interestingly, not all sfx is gone when the glitch occurs (also may be cause by going to the map and returning several times?)

I was going to put a list of sounds that do or don't work here, but its actually pretty sporadic which do or don't

some other things not working or not working properly -all areas are missing a background layer, if an area has only 1 bg layer, there is no bg aside from the base colour -text and menu sounds are not quite correct, they sound too fast? cut off? I can't quite put my finger on it, but I've replayed this game for years and some of them aren't right -saving at any statue gives the text 'saving failed!' instead of 'game saved!' but, is actually lying. saving and closing then reopening the game still shows your save as normal -some text on the map screen is really messed up (sunflower road and misty gorge especially)

also, using save codes does not work, but since saving actually does, you can still swap out .sol files

Flash:

https://user-images.githubusercontent.com/103858019/231255315-4c6c64e0-019f-4604-920b-a24ca99fdd84.mp4

Ruffle:

https://user-images.githubusercontent.com/103858019/231257194-e415b221-8ce9-4306-9d43-629ad026582e.mp4

Kz-92 commented 1 year ago

wad

the BG issue seems to have been fixed, but all other issues are still present

Kz-92 commented 1 year ago

tdyrs the start screen now shows up, but you still need to click the ad slot to start the game, unlike with flash all other issues are still present

Kz-92 commented 1 year ago

this seems to have massively been regressed on latest ruffle, I'm unable to even make a new save to test anything

https://github.com/ruffle-rs/ruffle/assets/103858019/193eab5c-dfaf-409a-9a3b-bb5bcb17f31e

n0samu commented 1 year ago

According to @Lord-McSweeney this regression was caused by #11169, which exposes the unimplemented void type

Lord-McSweeney commented 1 year ago

I can confirm that the regression is now fixed.

Kz-92 commented 1 year ago

here are the remaining issues, now that this can be tested again

pressing start at the preloader still requires you to click the ad slot instead
text, menu, and slingshot sounds are not correct (menu sounds are soft and text and slingshot sounds are too fast)
saving displays the message 'saving failed!' instead of 'game saved!' despite the message, your game really is saved
save codes can't be used (copy and paste menu is unavailable)
some area titles are messed up on the map screen (ex. sunflower road and misty gorge)

flash

https://github.com/ruffle-rs/ruffle/assets/103858019/93bc2dc6-b6d6-41a4-a7ea-9feb7f8f61b2

Ruffle

https://github.com/ruffle-rs/ruffle/assets/103858019/c871893e-eddd-4387-a8fe-4ea90789620c

n0samu commented 1 year ago

You can copy and paste with keyboard shortcuts in Ruffle, but indeed we don't have menu options for it yet.

Kz-92 commented 10 months ago

previous saving related issues, are now fixed. all others issues persist. a new problem is also revealed, where the ' < Enter Code > ' text is not removed on click of the text box of the save code loading feature, meaning if you then paste a save code, the code will be interrupted with parts of ' < Enter Code > ' and will so be invalid (unless you delete the characters beforehand).

flash

https://github.com/ruffle-rs/ruffle/assets/103858019/0a42782d-7206-438b-8cf8-7701f252071f

ruffle

https://github.com/ruffle-rs/ruffle/assets/103858019/9b2a70a6-15c7-430b-89a9-3e1ee7fc655f

kjarosh commented 12 hours ago

Progress of issues so far:

[x] pressing start at the preloader still requires you to click the ad slot instead
- I can click the text and it works
[x] save codes can't be used (copy and paste menu is unavailable)
- the save code is copied automatically, paste works and there's even a context menu for it
[x] the ' < Enter Code > ' text is not removed on click
- fixed
[x] saving displays the message 'saving failed!' instead of 'game saved!' despite the message, your game really is saved
- fixed, it says "Game Saved!"
[x] text, menu, and slingshot sounds are not correct (menu sounds are soft and text and slingshot sounds are too fast)
- they sound right IMO
[ ] some area titles are messed up on the map screen (ex. sunflower road and misty gorge)
- I have no idea how to open the map

Kz-92 commented 2 hours ago

the pressing start at the preloader, it isn't just the text that is normally able to be clicked (the whole area is actually clickable) (this also has been fixed for some time), but now on Ruffle the clickable area shows the cursor change when it should not. it does not change the cursor when hovering over the ad slot, but does outside of it; none should change it, as on flash

save codes now can be used, confirmed (I missed retesting this during my tests this year). I believe at the time of the comment, there was an issue with copy pasting menu on right click, which has definitely been resolved. (retested)

however, there is a related issue where pasting of the text does not scroll the text to the end as it should, instead showing the front of the code, where it should show the end. the text also goes past the box on the right slightly.

the ' < Enter Code > ' issue fixed, confirmed (retested)

saving has been fixed for some time, as mentioned on my comment, Jan 21st (retested)

flash https://github.com/user-attachments/assets/65897dd0-fa18-4930-a144-df7dca514435 ruffle https://github.com/user-attachments/assets/026ec5a5-f8b0-406c-b563-04ebc7cbe2d5

text audio is still not correct. (and has another bug that I will describe later) it seems faster and/or pitched differently still. inventory and other menu audio is much more subtle in difference, still a bit softer. slingshot sounds shockingly seem fixed. maybe still a bit fast. that is unexpected as I would think that all audio issues would be fixed at once. the rock bounce sfx is also missing, I believe this has been the case always on ruffle, but I never mentioned it somehow.

flash and ruffle audio comparison https://github.com/user-attachments/assets/b655e8a8-bad8-4e5b-8641-4d4732354dba

to open the map, you can leave the edge of the screen in some areas. the quickest way is right after talking to kitt in the kitchen, exit and run right for the bat. head back to the very left to the gate, hit it with your stick after equipped, climb down and leave left until you leave the screen. you also need to talk to alex for the location of sinflower road and honestly it might be easier if you had a save file instead if you'd like to test further. please message me on dscord if you'd like a save file.

https://github.com/user-attachments/assets/7560325c-2bf4-4aaf-8ef9-ef382ec8bb23

the non audio issues are more easily tested, but the audio related ones are difficult to convey due to so many differences in hearing, experince with the game, audio playback and sound reproduction through spreaks or headphones. I will try to find a better way to show the issues. I will still re record the problem in a video as I try to come up with a solution. I wear headphones but can also detect these differences without. it may be worth plugging in headphones to hear it for yourself.

there is also a slowdown problem later in the game but for now I will not be testing that further.

ruffle-rs / ruffle