search

rufman / license_checker

Tool to view and check license of a package's dependencies.
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

License checker trips up on sky_engine #45

Open leaf-node opened 3 weeks ago

leaf-node commented 3 weeks ago

At https://github.com/flutter/engine/blob/main/sky/packages/sky_engine/LICENSE, the license header is strangely formatted, but it starts with:

icu

#      Copyright (c) 2006-2015 International Business Machines Corporation,
  #      Apple Inc., and others. All Rights Reserved.

But the generated disclaimer says:

The following software may be included in this product: sky_engine
A copy of the source code may be downloaded from: http://flutter.io

This software contains the following license and notice below:
Copyright (c) 2006-2015 International Business Machines Corporation,
icu

#        #      Apple Inc., and others. All Rights Reserved.

I'm guessing that the script is only expecting one copyright author per license file?

leaf-node commented 3 weeks ago

I also noticed that sky_engine has a first line of icu in its upstream license. This shows up in the first disclaimer, but also shows up 441 times for me with the following command:

cat DISCLAIMER | grep "^icu$" | wc -l
441

It looks like the license checker is assuming that hundreds of package names are icu.