rugk / website-dark-mode-switcher

This is a (Firefox) add-on (WebExtension) that lets you invert the website's color scheme by inverting/changing the prefers-color-scheme media feature of CSS.
https://addons.mozilla.org/firefox/addon/dark-mode-website-switcher/?src=external-github-top
Other
58 stars 4 forks source link

implement optional syncing! #42

Open todo[bot] opened 2 years ago

todo[bot] commented 2 years ago

https://github.com/rugk/website-dark-mode-switcher/blob/f73db3235e83c3ad565712ede1c300f8df10be4b/src/common/modules/DarkModeLogic.js#L61-L66


This issue was generated by todo based on a TODO comment in f73db3235e83c3ad565712ede1c300f8df10be4b when #41 was merged. cc @rugk.
rugk commented 2 years ago

Background

I may want to disable syncing, because other connected devices may be used in a very different setting (place/location/time…) and there I need different settings (like "always dark" etc.)

Proposed solution

A setting ("Synchronize across devices", itself needs to be saved locally?, boolean/checkbox) that you can enable to enable synchronization. By default: Disabled, I guess. (Or enabled to ease migration from the current settings. :upside_down_face:)

The problem is our libs like AutomaticSettings never considered this use-case, so they only offer sync by-default, so either they This makes it a little more complicated.

Alternatives

Additional context