search

rugwizangoga / Todo-list-app

Todo list App is a simple web app that helps to organize your day. It simply lists the things that you need to do and allows you to mark them as complete, delete/Edit a task or add a new task and you can even clean all of the completed tasks if you want
https://rugwizangoga.github.io/Todo-list-app/dist/
MIT License
1 stars 0 forks source link

Do I follow JavaScript best practices? #5

Open rugwizangoga opened 1 year ago

rugwizangoga commented 1 year ago

I can say I tried to follow best practices especially HTML and CSS Best practices but there is still some issues when it comes to following JavaScript best practices

Below is a list of all issues I found in my Todo-list project:

rugwizangoga commented 1 year ago
  1. bad naming eg: https://github.com/rugwizangoga/Todo-list/blob/7c02968a96272fc1b5a89bb1b03990139c6fc3c2/src/CRUD.js#L7 , https://github.com/rugwizangoga/Todo-list/blob/7c02968a96272fc1b5a89bb1b03990139c6fc3c2/src/CRUD.js#L9 and https://github.com/rugwizangoga/Todo-list/blob/7c02968a96272fc1b5a89bb1b03990139c6fc3c2/src/CRUD.js#L13
  2. not DRY eg: https://github.com/rugwizangoga/Todo-list/blob/7c02968a96272fc1b5a89bb1b03990139c6fc3c2/src/CRUD.js#L14-L32