ruhigundrelaxed / ioBroker.hyperion

ioBroker Hyperion Adapter
MIT License
7 stars 8 forks source link

Think about to fix the issues found by adapter checker #24

Closed ioBrokerChecker closed 5 years ago

ioBrokerChecker commented 5 years ago

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:

https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/ruhigundrelaxed/ioBroker.hyperion

ERR:["E121","E125"]:ERR

Thanks, your automatic adapter checker.

ruhigundrelaxed commented 5 years ago

fixed e115, e121. e125 is false, e201 not yet

ldittmar81 commented 5 years ago

Hi,

E125 is really incomprehensible. What this means is that in the io-package still common.extIcon is missing. The text must be changed for the automatic check. See here an example:

https://github.com/ldittmar81/ioBroker.info/blob/master/io-package.json#L150

ruhigundrelaxed commented 5 years ago

Hi ldittmar, maybe I still don´t really get the point here. But common.extIcon is in line 23 of io-package.json. And if I follow the url I get the icon. I took a look at the example you provided but, beside the fact that i´m linking to a different icon, cannot find any differences in the way common.extIcon is provided. Maybe I´ve overseen something.

ldittmar81 commented 5 years ago

Soo.... jetzt mal ganz ruhig und relaxed. ;-) ... dein Link im extIcon muss auf https://raw.githubusercontent.com/ruhigundrelaxed/ioBroker.hyperion/master/admin/hyperion.png , denn dein aktueller Link zeigt nicht direkt auf die Datei, sondern auf eine html Seite. Du siehst es, wenn du dein Link im Browser eingibst. Da wirst du automatisch auf den richtigen Link verwiesen.

Beim E121 muss es authors heißen und das ist ein Array: siehe https://github.com/ldittmar81/ioBroker.info/blob/master/io-package.json#L140

Grüße, ldittmar

ruhigundrelaxed commented 5 years ago

Soo.... jetzt mal ganz ruhig und relaxed. ;-) Bin ich, bin ich. Per definition. ;-) Habs gefixed! Danke

ioBrokerChecker commented 5 years ago

Thanks, that all bugs have been fixed.