search

rukano / emacs-faust-mode

Faust major mode for editing faust code (.dsp files)
13 stars 7 forks source link

Play nice with Faustine #3

Closed yPhil-gh closed 7 years ago

yPhil-gh commented 7 years ago

(from https://bitbucket.org/yassinphilip/faustine/issues/1/heads-up-related-packages)

Guys, Faustine has been accepted in MELPA! :)

But now I realize that we can do a better job: The idea is to make Faustine depend on faust-mode, so as to clearly separate what does what: faust-mode does the syntax and the indenting, and Faustine contains the helper functions, and you can use the former without the latter, and not the opposite: Installing faustine would automatically install faust-mode as a dependancy.

So I would pull all the syntax-related code from Faustine, and put it in faust-mode. Note that my code is, shall I say better, at least more exhaustive, as I pulled all the keywords from the docs, using a specialized macro ; also it handles indentation, while faust-mode doesn't at the moment.

For that I would need write/push access to the repository, will you give it to me?

yPhil-gh commented 7 years ago

I guess what I'm suggesting is that, if this package needs a maintainer, I would gladly accept the honor :)

rukano commented 7 years ago

I would be glad to give you whire and push acces to this. :) Thanks for mantaining it and making it better! :)

On Mon, Sep 4, 2017 at 11:16 AM, Yassin Philip notifications@github.com wrote:

I guess what I'm suggesting is that, if this package needs a maintainer, I would gladly accept the honor :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rukano/emacs-faust-mode/issues/3#issuecomment-326911090, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF7c4nwbbkmw20sVU4UAkkxwfINcyX9ks5se8ALgaJpZM4PLp7f .

-- Juan Gabriel Alzate Romero http://rukano.de rukano@gmail.com

rukano commented 7 years ago

I sent you an invitation as a collaborator for the repo.

yPhil-gh commented 7 years ago

Thanks @rukano ! OK, I started to work on the refactoring, I was just wondering : How did you guys get this package into MELPA Stable? I understand @magnetophon handled this, is this some sort of automatic thing based on a git tag? Anyway, this will have to be done again once this endeavor (porting part of Faustine to Faust-mode) is finished and tested.

And more importantly, is it OK if I push my changes to master? Faust-mode is already a proper feature :)

Hey, judging from your website we may have more than Faust in common :)

magnetophon commented 7 years ago

@yassinphilip many thanks for making this better! Happy to see someone more qualified than me taking over. :)

If @rukano gives you access, I'll delete my clone, otherwise I can give you access.

MELPA stable works by git tag.

I'll go try out faustine now!

yPhil-gh commented 7 years ago

Well, I went with your fork since it's this one in MELPA ; thanks for giving me access ; The idea is that now we can all use Faustine :) Two things though: I couldn't find an email for your entries in the headers, and also about your references to Spacemacs (which seems to be some kind of monster I must admit) in the previous README I'm not sure if they are still accurate ; Related : Are there things to do in Faustine to be somehow compatible with the Faust huh, layer?

magnetophon commented 7 years ago

Well, I went with your fork since it's this one in MELPA ; thanks for giving me access ; The idea is that now we can all use Faustine :)

Thank YOU!

Two things though: I couldn't find an email for your entries in the headers,

It's bart@magnetophon.nl

and also about your references to Spacemacs (which seems to be some kind of monster I must admit) in the previous README I'm not sure if they are still accurate ; Related : Are there things to do in Faustine to be somehow compatible with the Faust huh, layer?

I incorporated Faustine in Spacemacs.