search

ruma / js_int

JavaScript-interoperable integer types for Rust
MIT License
16 stars 8 forks source link

add overflow_* methods, add docs #14

Closed DevinR528 closed 4 years ago

DevinR528 commented 4 years ago

Co-authored-by: Jonas Platte jplatte+git@posteo.de

DevinR528 commented 4 years ago

Should the Int also have wrapping and overflow methods?

jplatte commented 4 years ago

So there's one commented-out assert_eq I'm not too sure about (does it pass if not commented out?) and you named the methods overflow_ when they should be named overflowing_. Otherwise looks good on first glance.