run-house / runhouse

Dispatch and distribute your ML training to "serverless" clusters in Python, like PyTorch for ML infra. Iterable, debuggable, multi-cloud/on-prem, identical across research and production.
https://run.house
Apache License 2.0
981 stars 37 forks source link

Save ips as part of compute properties for ondemand clusters #1451

Closed carolineechen closed 1 week ago

sentry-io[bot] commented 1 week ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
up_if_not NotImplementedError: Cluster does not have an up method. It must be brought up manually. ...
Event Count: 2
up_if_not Exception: Received [403] from Den POST 'https://api.run.house/cluster/up': {'detail': 'Not authenticated'} ...
Event Count: 2
📄 File: runhouse/resources/hardware/on_demand_cluster.py (Click to Expand) | Function | Unhandled Issue | | :------- | :----- | | **`__init__`** | [**AttributeError: 'NoneType' object has no attribute 'startswith'**](https://runhouse.sentry.io/issues/6076181510/?referrer=github-open-pr-bot) runhouse.rns.rns_client in for...
`Event Count:` **1** |

Did you find this useful? React with a 👍 or 👎

carolineechen commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.