search

run-llama / llama_deploy

Deploy your agentic worfklows to production
https://docs.llamaindex.ai/en/stable/module_guides/llama_deploy/
MIT License
1.86k stars 193 forks source link

fix: remove timeout from the underlying network service #326

Closed masci closed 1 month ago

masci commented 1 month ago

Fixes #320

When deploying nested workflows, another "system" workflow NetworkWorkflow is started under the hood to provide a map workflow<-->service. This workflow has no timeout set, defaulting to 10s. But if the overall deployment requires more than 10 seconds to run, NetworkWorkflow will exit before the deployment can finish, causing #320

We should probably review the strategy of NetworkWorkflow, specially when nested workflows are involved, but for the time being this fix should be good.

I didn't find a way to meaningfully unit test this, and a proper e2e test would take >10s so I propose we don't test it.

coveralls commented 1 month ago

Coverage Status

coverage: 65.5%. remained the same when pulling 82da594384a448e136ea9a01af2a740c22afa0d2 on massi/320 into 0cfab66d73436c7678ad02e078958e4061059faf on main.