Fixes and additions for #8, #9 and #10

[ryancurrah]

All steps and model source

• Fix: Potential shell injection vulnerability https://github.com/rundeck-plugins/docker/issues/9

Run Image step

• Add: Ability to pass in multiple space delimited commands https://github.com/rundeck-plugins/docker/issues/10
• Add: Rundeck RD_OPTION, RD_NODE and RD_JOB environment variables are automatically passed to the container https://github.com/rundeck-plugins/docker/issues/8
• Changed: Surround docker run command argument values in single quotes to prevent spaces in arguments from breaking command

Plugin version

• Changed: Updated plugin version to 1.1.0

[ryancurrah]

Output of a test job execution of the run image step with these changes which executes the printenv command inside the container...

INFO: docker-run: Executing: 'docker run --env=RD_JOB_EXECUTIONTYPE='user' --env=RD_NODE_OS_NAME='Linux' --env=RD_NODE_OS_VERSION='3.140.0-112.el7.x86_64' --env=RD_JOB_RETRYATTEMPT='0' --env=RD_JOB_URL='https://rundeck.acme.com/project/PROJECT/execution/follow/1429' --env=RD_JOB_SUCCESSONEMPTYNODEFILTER='false' --env=RD_JOB_SERVERUUID='cdfdf3sd2-23ac-4567-b509-sawd2323' --env=RD_JOB_PROJECT='VRAM-OSDeployment' --env=RD_OPTION_ECHO='hey you' --env=RD_NODE_OS_FAMILY='unix' --env=RD_NODE_DESCRIPTION='Rundeck server node' --env=RD_JOB_ID='745cf2fe-35e5-4e1b-baa8-47be729b87f7' --env=RD_NODE_HOSTNAME='ACMENODE01' --env=RD_JOB_LOGLEVEL='INFO' --env=RD_JOB_NAME='TEST-DOCKER-PLUGIN' --env=RD_JOB_WASRETRY='false' --env=RD_NODE_OS_ARCH='amd64' --env=RD_JOB_EXECID='1429' --env=RD_JOB_THREADCOUNT='1' --env=RD_JOB_SERVERURL='https://rundeck.acme.com/' --env=RD_JOB_USERNAME='ryan.currah' --env=RD_JOB_USER_NAME='ryan.currah' --env=RD_NODE_NAME='ACMENODE01' --env=RD_NODE_USERNAME='rundeck' --detach='false' --env='ECHO=hey you' --env='BYE=OK' --rm='true' --tty='true' artifactory.acme.com:443/rundeck-agent:latest printenv' ...
INFO: docker-run: Command execution stdout: 'PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin
HOSTNAME=1d948f9e67f7
TERM=xterm
RD_JOB_EXECUTIONTYPE=user
RD_NODE_OS_NAME=Linux
RD_NODE_OS_VERSION=3.140.0-112.el7.x86_64
RD_JOB_RETRYATTEMPT=0
RD_JOB_URL=https://rundeck.acme.com/project/PROJECT/execution/follow/1429
RD_JOB_SUCCESSONEMPTYNODEFILTER=false
RD_JOB_SERVERUUID=cdfdf3sd2-23ac-4567-b509-sawd2323
RD_JOB_PROJECT=VRAM-OSDeployment
RD_OPTION_ECHO=hey you
RD_NODE_OS_FAMILY=unix
RD_NODE_DESCRIPTION=Rundeck server node
RD_JOB_ID=745cf2fe-35e5-4e1b-baa8-47be729b87f7
RD_NODE_HOSTNAME=ACMENODE01
RD_JOB_LOGLEVEL=INFO
RD_JOB_NAME=TEST-DOCKER-PLUGIN
RD_JOB_WASRETRY=false
RD_NODE_OS_ARCH=amd64
RD_JOB_EXECID=1429
RD_JOB_THREADCOUNT=1
RD_JOB_SERVERURL=https://rundeck.acme.com/
RD_JOB_USERNAME=ryan.currah
RD_JOB_USER_NAME=ryan.currah
RD_NODE_NAME=ACMENODE01
RD_NODE_USERNAME=rundeck
ECHO=hey you
BYE=OK
container=docker
PKGM=yum
HOME=/root
' ...
INFO: docker-run: Command execution stderr: '' ...