rundeck-plugins / rundeck-azure-plugin

8 stars 16 forks source link

RUN-912: Add methods needed for merged plugins #29

Closed mcat115 closed 2 years ago

mcat115 commented 2 years ago

I finally got access to azure so I was able to start testing, but I encountered a problem. With GCP, oracle, and AWS, once I moved the cloud plugins into the main repo, they were all in one place so they shared manager and manager builder files. But with the azure ones, many live in this repo (https://github.com/rundeck-plugins/rundeck-azure-plugin). This is different from the cloud repo, and I was told this one needs to stay a separate repo because it is open source. When the cloud plugins were separate they had their own manager file, but with me moving them now they lose it, and the methods they need. I can't add another AzureManager file to rundeckpro as it then errors and says there are two. When I trace the AzureManager with the undefined method in intellij it leads to a read only file from a library, instead of an editable manager like normal. My guess is to add the methods needed to the manager file in the other azure plugin repo (this one), and see if it can access them from there. Not sure if this is the case, but I can't test this idea without a separate PR being merged into main there, so I made it and thought I should request review on both to see what people think.