search

rundeck-plugins / rundeck-ec2-nodes-plugin

Get resource node data from Amazon EC2
86 stars 45 forks source link

Add check to confirm endpoint is set #120

Closed chrismcg14 closed 2 years ago

chrismcg14 commented 2 years ago

if endpoint isn't set, old behavior will now be used in else

qualman commented 2 years ago

Providing no endpoint/region is working:

Screen Shot 2022-05-10 at 11 10 26 Screen Shot 2022-05-10 at 11 10 20 Screen Shot 2022-05-10 at 11 10 04
qualman commented 2 years ago

Double-checking other options...

qualman commented 2 years ago

ALL_REGIONS: ✅

Screen Shot 2022-05-10 at 11 14 09
qualman commented 2 years ago

Comma-separated list: ✅

Screen Shot 2022-05-10 at 11 19 55 Screen Shot 2022-05-10 at 11 20 16
qualman commented 2 years ago

Tests pass:

Screen Shot 2022-05-10 at 11 21 22
qualman commented 2 years ago

Did a second pass on the code, looks good. Ready to go.