search

rundeck-plugins / rundeck-ec2-nodes-plugin

Get resource node data from Amazon EC2
86 stars 45 forks source link

Get all ec2 response pages #94

Closed ProTip closed 5 years ago

ProTip commented 5 years ago

Pages through the AWS request to ensure all instances are fetched. The query workflow has been collapsed into a single method to simplify the paging, and is run in background thread via the executor service.

ProTip commented 5 years ago

I have added a configuration option to set the max results per AWS request. Successfully smoked test this locally with the default and a page size of 5 and all nodes showing up.

gschueler commented 5 years ago

Rundeck manages caching and loading the nodes in separate threads within an executor already. This plugin has a toggle for "asynch" loading, which is disabled by default now due to this new-ish behavior in Rundeck. So i'd suggest that if the asynch==false, it should avoid using another thread

ProTip commented 5 years ago

@gschueler I believe the latest changes should address your feedback.

gschueler commented 5 years ago

fixes this? https://github.com/rundeck-plugins/rundeck-ec2-nodes-plugin/issues/76