runfinch / finch

The Finch CLI is an open source client for container development
https://www.runfinch.com
Apache License 2.0
3.59k stars 95 forks source link

ci: use setup-go for Windows and hardcode GO_VERSION #1183

Closed pendo324 closed 1 week ago

pendo324 commented 2 weeks ago

Issue #, if available:

Description of changes

Testing done

None, need to test this on the runners themselves.

Contribution agreement

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

austinvazquez commented 2 weeks ago

Curious if the enable cache change is intentional? For macOS e2e testing workflows cache writes takes 6-7 minutes due to cache size. These are also evicted quite quickly as we only have the default 10GB GitHub cache.

pendo324 commented 1 week ago

Curious if the enable cache change is intentional? For macOS e2e testing workflows cache writes takes 6-7 minutes due to cache size. These are also evicted quite quickly as we only have the default 10GB GitHub cache.

I thought that issue was resolved upstream, but I see they only have a workaround for Windows, not macOS. I'll make a new revision with cahceing disabled.