Illegal characters not properly reported to the user
When entering a device name in the installer, it's possible for the user to use characters that the Stormcloud server will reject on the back-end for security reasons. However, this error is not caught in a good spot, it will just give a generic "failed to install Stormcloud" error rather than giving specific information about not being able to use certain characters. The banned characters are defined in server_main in the passes_sanitize function:
If the user presents one of those characters, we should catch it in the client and give them a clean error message.
Issue with certain characters in file restore dashboard
Certain files appear to be unable to be added to the file restore menu if they contain certain characters in the filepath. Known problem paths (not sure if it is the - or & that is causing issues):
C:/Users/Ryan/Downloads/photos/Engagement Session/R&T-0191.jpg
Quality of Life -- installer file dialog
It would be nice if the installer could display files during the file dialog, currently it only displays folders (I think this is a PyQT-specific thing we might have to try and change). I think we should only allow folders to be selected, but display the files that are in the folders if possible.
Quality of Life -- restore selection interface
For devices that have lots of files, trying to restore many files can be difficult other than just selecting all. Not sure what the best way is to re-architect this, but it would be nice to improve, time permitting.
Illegal characters not properly reported to the user
When entering a device name in the installer, it's possible for the user to use characters that the Stormcloud server will reject on the back-end for security reasons. However, this error is not caught in a good spot, it will just give a generic "failed to install Stormcloud" error rather than giving specific information about not being able to use certain characters. The banned characters are defined in
server_mainin thepasses_sanitizefunction:SANITIZE_LIST = ["'", '"', ";", "\\", "--", "*", "%"]If the user presents one of those characters, we should catch it in the client and give them a clean error message.
Issue with certain characters in file restore dashboard
Certain files appear to be unable to be added to the file restore menu if they contain certain characters in the filepath. Known problem paths (not sure if it is the - or & that is causing issues):
C:/Users/Ryan/Downloads/photos/Engagement Session/R&T-0191.jpgQuality of Life -- installer file dialog
It would be nice if the installer could display files during the file dialog, currently it only displays folders (I think this is a PyQT-specific thing we might have to try and change). I think we should only allow folders to be selected, but display the files that are in the folders if possible.
Quality of Life -- restore selection interface
For devices that have lots of files, trying to restore many files can be difficult other than just selecting all. Not sure what the best way is to re-architect this, but it would be nice to improve, time permitting.