search

rursprung / fhgr-mrproj2

A ROS 1 based tank with a LIDAR.
GNU General Public License v3.0
2 stars 2 forks source link

Add video recorder WIP #44

Closed joel5399 closed 1 year ago

joel5399 commented 1 year ago

Added a new Package to record videos while driving.

Somehow i messed up with the other branches... so like last time every commit is in this Pull request.

rursprung commented 1 year ago

we discussed last week that this would probably not be needed as you anyway only get 1-2FPS with this solution. you anyway only wanted to create the recording so that the QR code finder can be implemented using real video, right? a better solution might be to simply record some video on the ROS topic using rosbag. then that can be used to implement the ROS -> OpenCV functionality where we can include the video export functionality (either as an optional feature or just briefly locally w/o committing it) which can then be run on a desktop where the performance is decent. or, if development of the image analysis functionality anyway also happens in an Ubuntu 20.04 VM (set up for ROS) then the video doesn't need to be saved at all and the rosbag can be used directly for that.

@joel5399: based on this i'm currently skipping the review for this PR. if you still want it to be reviewed please update the branch to only include that commit and not the others as well (i think we already did that together and you just haven't pushed it yet?). otherwise please close the PR.