search

rusefi / rusefi-hardware

15 stars 19 forks source link

bad yaml interactive pinout did not fail #259

Closed rusefillc closed 9 months ago

rusefillc commented 9 months ago

https://github.com/rusefi/rusefi-hardware/tree/main/Toyota-JZA80/connectors contained bad yaml but https://github.com/rusefi/rusefi-hardware/actions/runs/7993182318/job/21828392715 did not fail

expected: failed job

rusefillc commented 9 months ago

@chuckwagoncomputing is that github action problem here or https://github.com/chuckwagoncomputing/interactive-pinout defect?

chuckwagoncomputing commented 9 months ago

It did produce no-cid, no-image, and no-pins warnings. In the workflow file, you could change warnings: "false" to warnings: "error" to make any error cause the workflow to fail. Or you could get more specific with something like warning-no-pins: "error". Here are the warning parameters, though I see that I don't have the possible values listed. I'll have to fix that.

rusefillc commented 9 months ago

@chuckwagoncomputing so https://github.com/rusefi/rusefi-hardware/commit/438a45d7ff805adb57441960c9a4e64cd7adb693 is what I need in all my GHA jobs?

chuckwagoncomputing commented 9 months ago

Possibly. I would also recommend warnings: notice instead of warnings: false. That will make warnings more noticeable.