cenkakin
commented
7 years ago I forked your repo and started to use in Android platform. I noticed there are breaking changes with the last version 0.1.6 and also some features are broken.
Here are some points I noticed:
- 'Subscribe' method is deleted.
- 'data' event name is changed to 'read'
- 'read' and 'readUntilDelimiter' are not working completely. Because on data read event, the value is not appended to string buffer.
- RN 0.40.0 is added as a dependency. It is not a good practice, there might be collisions with root project's dependencies. Most plugins are forced to use specific RN version by giving peerDependencies version.
I fixed those issues. I would look forward to your reply.
resolved #24
Can you release a new version? You fixed a lot of bugs and improved new features since the last version was released. A couple of issues will be also closed by doing that.